-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chained controllers example #162
Chained controllers example #162
Conversation
3c6eb16
to
056b06b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Good demo with multiple levels to showcase chainable controllers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All instructions were executed and the results were as expected.
Nice work once again!
056b06b
to
de0662d
Compare
How can this be integrated? Can we merge ros-controls/ros2_controllers#318 into master or create an example without the need for custom ros2_controllers? The status of ros-controls/ros2_controllers#318 is currently broken (no tf messages, and there is a merge conflict with master which I did not investigate this further) |
No idea, we will probably have to kill this PR and get some better examples when more controllers get chainable options |
@christophfroehlich Maybe this PR can be closed as we already have it in example_12 ? |
To test the example, checkout the following branches and following dependencies:
ros-controls/ros2_control#667
ros-controls/ros2_controllers#318
Then, follow the instructions in README added in this PR.